Conversation
added 2 commits
April 8, 2021 15:17
ghost
changed the title
willscott
reviewed
Apr 12, 2021
|
|
||
| Input: | ||
|
|
||
| - A list of `{miner,CID}` tuples to be retrieved |
Contributor
There was a problem hiding this comment.
how do you imagine inputting this?
Author
There was a problem hiding this comment.
I'm imaging a text file like a CSV. But I think @ribasushi can give us another format like json (any format within reason).
Here's the only catch. We won't get the entire list at once. It will be a new list every few days since a human is the one finding the CIDs. @willscott telll me if you see any problem with that.
| #### What does done look like? | ||
| _What specific deliverables should completed to consider this project done?_ | ||
|
|
||
| - The go-ipfs node (to be set up by @ribasushi outside this project proposal) should contain the retrieved bits of all successful retrieval |
Contributor
There was a problem hiding this comment.
this seems separate from the controller work, though?
Author
There was a problem hiding this comment.
Yes, it is separate from the controller. I just wanted to capture it here because it'll mean small config changes in the Lotus instance used in the controller project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial proposal for the Slingshot controller.